-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint task in CI #5100
Fix lint task in CI #5100
Conversation
Skipping CI for Draft Pull Request. |
(Draft because I'm sending a dummy change to verify, first) |
The lint task was failing at head, due to a nolint:exhaustive error directive that golangci nolintlint believes is unused. Issue seems to be golangci/golangci-lint#3228 and seems to be a bug in golang-ci / nolintlint, using the workaround proposed in golangci/golangci-lint#1940 which is to clear the cache between runs.
For other reviewers, you can see the failure that this PR fixes here: https://github.com/kubernetes-sigs/kustomize/actions/runs/4469313594/jobs/7851240777?pr=5099 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The lint task was failing at head.