Add test for issue #5131 #5189
Merged
Add test for issue #5131 #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
annasong20
force-pushed
the
test-relative-submodules
branch
from
077c2b4
to
cfe8ead
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @varshaprasad96 |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
added
lgtm
|
@annasong20 Thanks for the PR! Looks like it needs to be rebased. Else looks good to me. |
annasong20
force-pushed
the
test-relative-submodules
branch
from
cfe8ead
to
129d0f9
Compare
k8s-ci-robot
removed
the
lgtm
@varshaprasad96 Rebased! |
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annasong20, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test for issue #5131 - relative path to submodules need
origin. This PR demonstrates the issue so that we can be confident #5183 fixes it.