Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: local helm chart with version but no repo #5293

Merged
merged 6 commits into from Nov 2, 2023
Merged

fix: local helm chart with version but no repo #5293

merged 6 commits into from Nov 2, 2023

Commits on Nov 1, 2023

  1. Fix using same helm chart with different versions (kubernetes-sigs#4999) 

    * Fix using same helm chart with different versions

* Fix p.ValuesFile when version is set

* Updated: Fix using same helm chart with different versions

* Add test for issue kubernetes-sigs#4813

* Use if/else for readability, add version check to absChartHome
    @dlish @ardikabs
    dlish authored and ardikabs committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a0f131c View commit details
    Browse the repository at this point in the history

  2. fix: fix while using local charts with version 

    fix kubernetes-sigs#5163

Signed-off-by: Ardika Bagus <me@ardikabs.com>
    @ardikabs
    ardikabs committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    cc35d3c View commit details
    Browse the repository at this point in the history

  3. chore: fix lint, assert with required

    @ardikabs
    ardikabs committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    5505af4 View commit details
    Browse the repository at this point in the history

  4. chore: remove unnecessary code, and using testdata instead of inline 

    Signed-off-by: Ardika Bagus <me@ardikabs.com>
    @ardikabs
    ardikabs committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b7b85b1 View commit details
    Browse the repository at this point in the history

  5. chore: rename chart and test case with clear intention

    @ardikabs
    ardikabs committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    790dbf0 View commit details
    Browse the repository at this point in the history

  6. test: add Kustomize test case for multiple helm charts with different… 

    … version

Signed-off-by: Ardika Bagus <me@ardikabs.com>
    @ardikabs
    ardikabs committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    6640f87 View commit details
    Browse the repository at this point in the history