Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add remove configmap command #5327

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat: add remove configmap command #5327

merged 3 commits into from
Sep 20, 2023

Conversation

stormqueen1990
Copy link
Member

This is a cherry-pick from PR #4796 commits, with an extra commit to incorporate feedback left on the original PR.

Related issue: #4493

yufeiminds and others added 2 commits September 12, 2023 19:21
@yufeiminds @stormqueen1990
feat: add remove configmap command
0cdfa5b 
(cherry picked from commit 0d7c56d)

fix: add logging when configmap not exists

(cherry picked from commit 0235f10)

fix: correct lint issues

(cherry picked from commit 8ca1f38)

fix: Resolve conversation

(cherry picked from commit 927804d)
@stormqueen1990
Incorporate feedback from original PR
0571a2f 
* Incorporate feedback left on original PR.
* Add more test cases.
* Minor refactoring and update to copyright notice.
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2023
@stormqueen1990 stormqueen1990 mentioned this pull request Sep 13, 2023
Closed
@stormqueen1990
Copy link
Member Author

/cc @natasha41575

natasha41575
natasha41575 reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM. A few nits.

kustomize/commands/edit/remove/removeconfigmap.go Outdated Show resolved Hide resolved
kustomize/commands/edit/remove/removeconfigmap_test.go Outdated Show resolved Hide resolved
kustomize/commands/edit/remove/removeconfigmap_test.go Outdated Show resolved Hide resolved
kustomize/commands/edit/remove/removeconfigmap_test.go Outdated Show resolved Hide resolved
@natasha41575
Copy link
Contributor

fyi, I'm moving this straight to needs approval since we already reviewed and lgtm'd the original PR together

@stormqueen1990
fix: changes from code review
9107fa3 
* Replace last assert directive with require in the test.
* Change copyright notice.
natasha41575
natasha41575 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to have your first contribution! Thanks so much :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, stormqueen1990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1bd58bd into kubernetes-sigs:master Sep 20, 2023
9 checks passed
@stormqueen1990 stormqueen1990 deleted the feat/add-remove-configmap-command branch September 21, 2023 01:17
@stormqueen1990 stormqueen1990 mentioned this pull request Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 approved these changes

@annasong20 annasong20 Awaiting requested review from annasong20

@koba1t koba1t Awaiting requested review from koba1t

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Kustomize Commands outside of `build`
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stormqueen1990 @k8s-ci-robot @natasha41575 @yufeiminds