Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move removetest.go to the internal package #5495

Merged
merged 3 commits into from Dec 22, 2023
Merged

chore: move removetest.go to the internal package #5495

merged 3 commits into from Dec 22, 2023

Conversation

stormqueen1990
Copy link
Member

  • Move the edit/remove_test/removetest.go file to the internal package, as it is intended to aid testing.
  • Rename the method ExecuteTestCases to ExecuteRemoveTestCases.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2023
@stormqueen1990 stormqueen1990 force-pushed the chore/removetest-internal-package branch from 8053740 to 16ca8e1 Compare December 20, 2023 23:51
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

koba1t
koba1t reviewed Dec 21, 2023
View reviewed changes
kustomize/commands/internal/testutils/remove_testutils.go
@@ -41,16 +40,20 @@ type Case struct {
Expected Expected
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, Maybe those global struct names are a little generic more than real functions.
If you can, Could you rename those to a more small scope name? (ex, add the Remove prefix, It's only my idea.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Maybe RemoveTestCase?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koba1t updated! Could you PTAL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stormqueen1990
chore: move removetest.go to the internal package
f814039 
* Move the edit/remove_test/removetest.go file to the internal package, as it is
  intended to aid testing.
* Rename the method ExecuteTestCases to ExecuteRemoveTestCases.
@stormqueen1990
chore: move removetest_testutils.go to internal/testutils
42d5870
@stormqueen1990
fix: rename helper structs to use more specific names
27ae069
@stormqueen1990 stormqueen1990 force-pushed the chore/removetest-internal-package branch from 16ca8e1 to 27ae069 Compare December 22, 2023 03:53
@koba1t
Copy link
Member

koba1t commented Dec 22, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, stormqueen1990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0c461d6 into kubernetes-sigs:master Dec 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 Awaiting requested review from natasha41575

@koba1t koba1t Awaiting requested review from koba1t

Assignees

@koba1t koba1t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Kustomize Commands outside of `build`
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stormqueen1990 @k8s-ci-robot @koba1t