docs: add favicons

[loffing]

Addresses #5312 by adding favicons based on those used on kustomize.io

[k8s-ci-robot]

Welcome @loffing!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @loffing. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[charles-chenzz]

the typos was good catch! Thank you
but when I manually check kustomize.io I seen the icon is already replace, which site that this PR trying to add favicons?

[loffing]

@charles-chenzz Thanks for the review!

As @natasha41575 mentioned here, the issue associated with this PR is concerned with the site directory in this repo, not the current kustomize.io.

My understanding is that the long-term goal is to replace the current content at kustomize.io with the content of the site directory, as described in #4338.

[charles-chenzz]

@charles-chenzz Thanks for the review!

As @natasha41575 mentioned here, the issue associated with this PR is concerned with the site directory in this repo, not the current kustomize.io.

My understanding is that the long-term goal is to replace the current content at kustomize.io with the content of the site directory, as described in #4338.

Thanks for clarifying it!

If you are looking at kustomize.io, that is the site that we are trying to replace and is unrelated to the site directory that is sitting in this repo

I misunderstood this sentence.

one more question: the pixel that you set, have you tried it locally?

[loffing]

@charles-chenzz Yep, I verified the new icons by running hugo serve locally. The filenames and dimensions match those of the template files, so they should work the same way.

[loffing]

@charles-chenzz Any other questions/feedback?

[charles-chenzz]

Generally lgtm to me(was on vacation sry) /lgtm T. Cheyney Loffing ***@***.***>于2023年12月31日 周日10:57写道：

…

@charles-chenzz <https://github.com/charles-chenzz> Any other questions/feedback? — Reply to this email directly, view it on GitHub <#5498 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARPM5YCMUHY7YM7ERQQ4GKTYMDICRAVCNFSM6AAAAABBAR6HRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGY2TKOBWHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: loffing

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment