Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 'golang.org/x/exp/slices' dependencies #5567

Merged
merged 1 commit into from Mar 20, 2024
Merged

fix 'golang.org/x/exp/slices' dependencies #5567

merged 1 commit into from Mar 20, 2024

Conversation

koba1t
Copy link
Member

@koba1t koba1t commented Mar 9, 2024

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 9, 2024
@koba1t
Copy link
Member Author

koba1t commented Mar 9, 2024

/hold, wait to upgrade for go 1.21
https://go.dev/blog/go1.21

stormqueen1990
stormqueen1990 reviewed Mar 10, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Leaving my LGTM in advance, but am thinking that perhaps we could apply a go work sync separately?
It appears we have a bunch of dependencies that could be version bumped.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2024
@koba1t koba1t force-pushed the remove_exp_slices_dependencies branch from b6c1121 to 86d7a3c Compare March 14, 2024 13:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koba1t
Copy link
Member Author

koba1t commented Mar 14, 2024

we could apply a go work sync separately?

That makes sense!

stormqueen1990
stormqueen1990 reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@koba1t koba1t force-pushed the remove_exp_slices_dependencies branch from 86d7a3c to 75d618e Compare March 20, 2024 17:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@koba1t koba1t force-pushed the remove_exp_slices_dependencies branch from 75d618e to 72f0a3c Compare March 20, 2024 17:12
@koba1t koba1t marked this pull request as ready for review March 20, 2024 17:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
stormqueen1990
stormqueen1990 reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit a6ea3e2 into kubernetes-sigs:master Mar 20, 2024
10 checks passed
@koba1t koba1t deleted the remove_exp_slices_dependencies branch March 20, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormqueen1990 stormqueen1990 stormqueen1990 left review comments

@ncapps ncapps Awaiting requested review from ncapps

Assignees

@stormqueen1990 stormqueen1990

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@koba1t @k8s-ci-robot @stormqueen1990