Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error msg returned when no kustomization file is found #771

Merged
merged 1 commit into from Feb 7, 2019

Conversation

alexbrand
Copy link
Contributor

Initial attempt at improving the error message so that the user knows which files are supported by kustomize.

Very much open to feedback on wording, structure, etc.

Fixes #770

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2019
@Liujingfang1
Copy link
Contributor

Liujingfang1 commented Feb 7, 2019

@alexbrand go fmt failed in ci.

pkg/target/kusttarget.go:91: line is 185 characters (lll)
		return nil, fmt.Errorf("No kustomization file found in %s. Kustomize supports the following kustomization files: %s", ldr.Root(), strings.Join(constants.KustomizationFileNames, ", "))

Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
@alexbrand
Copy link
Contributor Author

Just updated to fix the line length. Thanks!

@Liujingfang1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@Liujingfang1 Liujingfang1 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: alexbrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ce7e5ee into kubernetes-sigs:master Feb 7, 2019
@alexbrand alexbrand deleted the fix-error-msg branch February 8, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants