Add Test Cases for slices package #1084

joeyyy09 · 2024-05-16T19:25:46Z

What type of PR is this?

/kind test

What this PR does / why we need it:

Adds comprehensive test cases for the slices package to ensure thorough coverage and functionality.

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

No.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

k8s-ci-robot · 2024-05-16T19:25:49Z

@joeyyy09: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind test

What this PR does / why we need it:

Adds comprehensive test cases for the slices package to ensure thorough coverage and functionality.

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

No.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

linux-foundation-easycla · 2024-05-16T19:25:50Z

The committers listed above are authorized under a signed CLA.

✅ login: joeyyy09 / name: Harshith Mente (d5984c8, 8ee8fad, 270971e)

k8s-ci-robot · 2024-05-16T19:25:55Z

Welcome @joeyyy09!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-05-16T19:25:55Z

Hi @joeyyy09. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-05-16T19:26:04Z

✅ Deploy Preview for k8s-kwok canceled.

Name	Link
🔨 Latest commit	`d5984c8`
🔍 Latest deploy log	https://app.netlify.com/sites/k8s-kwok/deploys/6646eea591a33800080137ce

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

joeyyy09 · 2024-05-16T19:43:16Z

I updated the interface settings from args[S interface{ ~[]T }, T comparable] struct { to testCase[S ~[]T, T comparable] struct { for clarity and consistency. This change simplifies the interface definition while still ensuring that the types remain compatible with the requirements of the test cases. By using testCase instead of args, it more accurately reflects the purpose of the struct in the context of our test cases.

joeyyy09 · 2024-05-16T19:44:39Z

I modified the error handling logic to combine the error check with the condition for os.IsNotExist(err). This change simplifies the control flow by reducing nesting and makes the code easier to read. Now, if the error is not nil and not related to file not found (os.IsNotExist), we handle it accordingly. This refactor helped fix the linting issues i was facing

wzshiming · 2024-05-17T03:01:07Z

/ok-to-test

wzshiming · 2024-05-17T03:04:34Z

I modified the error handling logic to combine the error check with the condition for os.IsNotExist(err). This change simplifies the control flow by reducing nesting and makes the code easier to read. Now, if the error is not nil and not related to file not found (os.IsNotExist), we handle it accordingly. This refactor helped fix the linting issues i was facing

It breaks the original logic, and I'm not sure the unit test covered this change.

wzshiming

The test is look good, then revert content that is not in the title.

pkg/kwok/server/debugging_logs.go

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

joeyyy09 · 2024-05-17T05:49:10Z

The test is look good, then revert content that is not in the title.

Yeah, i've reverted back the changes

wzshiming · 2024-05-17T08:07:11Z

/approve
/lgtm
/release-note-none
/label tide/merge-method-squash

k8s-ci-robot · 2024-05-17T08:07:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joeyyy09, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wzshiming]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Add Test Cases for slices package Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> * Fix linting issues Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> * Fix linting issues Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> --------- Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> adding sets_test.go

* Add Test Cases for slices package Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> * Fix linting issues Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> * Fix linting issues Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> --------- Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Add Test Cases for slices package

8ee8fad

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 16, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 16, 2024

k8s-ci-robot requested review from yibozhuang and yuanchen8911 May 16, 2024 19:25

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 16, 2024

Fix linting issues

270971e

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2024

wzshiming reviewed May 17, 2024

View reviewed changes

pkg/kwok/server/debugging_logs.go Outdated Show resolved Hide resolved

Fix linting issues

d5984c8

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

k8s-ci-robot assigned wzshiming May 17, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024

k8s-ci-robot merged commit 85fc8f6 into kubernetes-sigs:main May 17, 2024
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Test Cases for slices package #1084

Add Test Cases for slices package #1084

joeyyy09 commented May 16, 2024

k8s-ci-robot commented May 16, 2024

What type of PR is this?

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla bot commented May 16, 2024 •

edited

k8s-ci-robot commented May 16, 2024

k8s-ci-robot commented May 16, 2024

netlify bot commented May 16, 2024 •

edited

joeyyy09 commented May 16, 2024

joeyyy09 commented May 16, 2024

wzshiming commented May 17, 2024

wzshiming commented May 17, 2024 •

edited

wzshiming left a comment

joeyyy09 commented May 17, 2024

wzshiming commented May 17, 2024

k8s-ci-robot commented May 17, 2024

Add Test Cases for slices package #1084

Add Test Cases for slices package #1084

Conversation

joeyyy09 commented May 16, 2024

What type of PR is this?

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented May 16, 2024

What type of PR is this?

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla bot commented May 16, 2024 • edited

k8s-ci-robot commented May 16, 2024

k8s-ci-robot commented May 16, 2024

netlify bot commented May 16, 2024 • edited

✅ Deploy Preview for k8s-kwok canceled.

joeyyy09 commented May 16, 2024

joeyyy09 commented May 16, 2024

wzshiming commented May 17, 2024

wzshiming commented May 17, 2024 • edited

wzshiming left a comment

Choose a reason for hiding this comment

joeyyy09 commented May 17, 2024

wzshiming commented May 17, 2024

k8s-ci-robot commented May 17, 2024

linux-foundation-easycla bot commented May 16, 2024 •

edited

netlify bot commented May 16, 2024 •

edited

wzshiming commented May 17, 2024 •

edited