Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kwokctl] Support snapshot export with record #884

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[kwokctl] Support snapshot export with record #884

merged 1 commit into from
Feb 1, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Dec 25, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
Base on #880

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Support snapshot export with record

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 25, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 25, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 25, 2023 •
edited

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 4b93c43
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/65bb04bbc919940008663f6b

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 25, 2023
@wzshiming wzshiming force-pushed the feat/snapshot-export-record branch 5 times, most recently from 23ba1c3 to 102a16c Compare December 29, 2023 02:59
@wzshiming wzshiming mentioned this pull request Jan 3, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 8, 2024
@wzshiming wzshiming force-pushed the feat/snapshot-export-record branch 3 times, most recently from a4f964c to 07a9f60 Compare January 9, 2024 11:42
@wzshiming wzshiming force-pushed the feat/snapshot-export-record branch 3 times, most recently from 72d6ec2 to 2167dd6 Compare January 18, 2024 15:18
@wzshiming wzshiming force-pushed the feat/snapshot-export-record branch 2 times, most recently from 68e9ef1 to bdf33fd Compare January 29, 2024 03:23
@k8s-ci-robot k8s-ci-robot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 29, 2024
@wzshiming wzshiming force-pushed the feat/snapshot-export-record branch 5 times, most recently from ccabed2 to 0db6b89 Compare January 31, 2024 06:07
@wzshiming wzshiming changed the title [WIP] [kwokctl] Support snapshot export with record [kwokctl] Support snapshot export with record Jan 31, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@wzshiming wzshiming force-pushed the feat/snapshot-export-record branch 2 times, most recently from 8266a6d to e35afa1 Compare January 31, 2024 10:23
@wzshiming wzshiming merged commit a6ee84e into kubernetes-sigs:main Feb 1, 2024
27 of 29 checks passed
@wzshiming wzshiming deleted the feat/snapshot-export-record branch February 1, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wzshiming @k8s-ci-robot