fix VerbosityZero check panic

kubernetes-sigs · Aug 31, 2022 · f60c7b1 · f60c7b1
1 parent f68289b
commit f60c7b1
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/logcheck/pkg/logcheck.go b/logcheck/pkg/logcheck.go
@@ -537,11 +537,14 @@ func isVerbosityZero(expr ast.Expr) bool {
 		return false
 	}
 
-	if lit, ok := subCallExpr.Args[0].(*ast.BasicLit); ok && lit.Value == "0" {
-		return true
+	if lit, ok := subCallExpr.Args[0].(*ast.BasicLit); ok {
+		if lit.Value == "0" {
+			return true
+		}
+		return false
 	}
 
-	if id, ok := subCallExpr.Args[0].(*ast.Ident); ok && id.Obj.Kind == 2 {
+	if id, ok := subCallExpr.Args[0].(*ast.Ident); ok && id.Obj != nil && id.Obj.Kind == 2 {
 		v, ok := id.Obj.Decl.(*ast.ValueSpec)
 		if !ok || len(v.Values) != 1 {
 			return false