Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for interface inheritance #15

Merged
merged 2 commits into from
May 11, 2023
Merged

check for interface inheritance #15

merged 2 commits into from
May 11, 2023

Commits on May 11, 2023

  1. logcheck: consolidate key/value checking 

    The two flavors of key checking (plain ASCII and the stricter Kubernetes
guidelines) are now done in the same function. This is a first step towards
also checking values in that same function.

While at it, a small bug for format specifier checking of klog calls gets
fixed: it was done twice, once without honoring the enable flag for it.
    @pohly
    pohly committed May 11, 2023
    Configuration menu
    Copy the full SHA
    b040e25 View commit details
    Browse the repository at this point in the history

  2. logcheck: check that fmt.Stringer gets implemented properly 

    If a type inherits String from some embedded field, then the klog text output
will only print the result of that function call, which then includes only
information about the embedded field (example:
kubernetes/kubernetes#115950).

The right solution for this problem is TBD.
    @pohly
    pohly committed May 11, 2023
    Configuration menu
    Copy the full SHA
    137dd42 View commit details
    Browse the repository at this point in the history