-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other merges added #366
Other merges added #366
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: satyampsoni The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
* [Enhanced Progress Notification Timing for Improved Reliability](https://github.com/kubernetes/kubernetes/pull/125115) | ||
|
||
* Updated the Kubernetes repository to use [`registry.k8s.io/pause:3.10`](https://github.com/kubernetes/kubernetes/pull/125112) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This belongs in Version Updates
@@ -29,8 +29,42 @@ CBOR support was proposed by [Ben Luddy in 2019](https://github.com/kubernetes/e | |||
|
|||
|
|||
## Other Merges | |||
* [Enhanced Validation for List Parameters in client-go](https://github.com/kubernetes/kubernetes/pull/125166) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use normal sentence case, please.
* [Enhanced Validation for List Parameters in client-go](https://github.com/kubernetes/kubernetes/pull/125166) | |
* [Enhanced validation for list parameters in client-go](https://github.com/kubernetes/kubernetes/pull/125166) |
* Added [`Set` Method](https://github.com/kubernetes/kubernetes/pull/125052 ) to Envvar Implementation in | ||
client-go. | ||
|
||
* [Deprecated the RootlessControlPlane feature gate](https://github.com/kubernetes/kubernetes/pull/124997 ) in Kubedam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This belongs in deprecations
|
||
* Updated the Kubernetes repository to use [`registry.k8s.io/pause:3.10`](https://github.com/kubernetes/kubernetes/pull/125112) | ||
|
||
* [Added -v Flag to Windows Pause Binary](https://github.com/kubernetes/kubernetes/pull/125067 ) Promotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No periods, per style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this should mention what the flag does
* [Added -v Flag to Windows Pause Binary](https://github.com/kubernetes/kubernetes/pull/125067 ) Promotes | ||
Consistency Across Platforms. | ||
|
||
* Added [`Set` Method](https://github.com/kubernetes/kubernetes/pull/125052 ) to Envvar Implementation in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should mention what the method accomplishes
|
||
* [Deprecated the RootlessControlPlane feature gate](https://github.com/kubernetes/kubernetes/pull/124997 ) in Kubedam. | ||
|
||
* [The `horizontal-pod-autoscaler-upscale-delay` and `horizontal-pod-autoscaler-downscale-delay` flags have been removed](https://github.com/kubernetes/kubernetes/pull/124948) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this belongs in deprecations
|
||
* [The `horizontal-pod-autoscaler-upscale-delay` and `horizontal-pod-autoscaler-downscale-delay` flags have been removed](https://github.com/kubernetes/kubernetes/pull/124948) | ||
|
||
* [All waitingPods in scheduler now can be obtained from any profiles](https://github.com/kubernetes/kubernetes/pull/124926) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was in last week's LWKD, always worth checking
|
||
* [ Container restart due to pod spec field changes has been fixed.](https://github.com/kubernetes/kubernetes/pull/124220) | ||
|
||
* [ Added Mount tmpfs memory-backed volumes with a noswap option if supported.](https://github.com/kubernetes/kubernetes/pull/124060) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where possible, only have a few of the words be the link. for example, here it should just be [tmpfs memory-backed volumes]. Also, the change here is the noswap option, not tmpfs support, which already existed
|
||
* Improved [Generalization of `checkWatchListConsistencyIfRequested`](https://github.com/kubernetes/kubernetes/pull/124446 ) in client-go. | ||
|
||
* [ Container restart due to pod spec field changes has been fixed.](https://github.com/kubernetes/kubernetes/pull/124220) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right this as what it does, rather than "has been fixed". "Pod spec field changes will not trigger container restart"
* Client-go/reflector: [warns on the missing bookmark events](https://github.com/kubernetes/kubernetes/pull/124614) | ||
* [Fixed Azure Disk PV Topology Label Issues](https://github.com/kubernetes/kubernetes/pull/124528 )with External Cloud Provider. | ||
|
||
* kubeadm [Updated to Use etcd 3.5.11's](https://github.com/kubernetes/kubernetes/pull/124465) New Liveness and Readiness Endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This belongs in Version Updates
I marked this up for improving your text in the future. I'm merging it, though, so I can release the edition today. |
No description provided.