New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement -max-header flag #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thockin -- For clarity, could we call the flag max-depth
instead?
i.e., since this is a TOC package, we know that the flags apply to TOC config, but I might incorrectly assume that max-header
refers to the amount of headings I'm allowed to use.
By your command - re-pushed
…On Sat, Feb 6, 2021 at 2:20 PM Stephen Augustus ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@thockin <https://github.com/thockin> -- For clarity, could we call the
flag max-depth instead?
i.e., since this is a TOC package, we know that the flags apply to TOC
config, but I might incorrectly assume that max-header refers to the
amount of headings I'm allowed to use.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVCXUQLAPDYBCFEARDDS5W6CVANCNFSM4XFSFMJQ>
.
|
Thanks Tim! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #8
@justaugustus