Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad architecture metadata in k8s.gcr.io images #848

Closed
paleozogt opened this issue Sep 28, 2021 · 3 comments · Fixed by #882
Closed

bad architecture metadata in k8s.gcr.io images #848

paleozogt opened this issue Sep 28, 2021 · 3 comments · Fixed by #882
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@paleozogt
Copy link

What happened:

While thek8s.gcr.io/metrics-server/metrics-server images are multi-arch, the architecture metadata in each image is incorrect.

For example, all the images have amd64 as their architecture:

$ docker pull --platform linux/arm64/v8 k8s.gcr.io/metrics-server/metrics-server:v0.5.1
$ docker inspect k8s.gcr.io/metrics-server/metrics-server:v0.5.1 | grep Arch
        "Architecture": "amd64",

$ docker pull --platform linux/ppc64le k8s.gcr.io/metrics-server/metrics-server:v0.5.1
$ docker inspect k8s.gcr.io/metrics-server/metrics-server:v0.5.1 | grep Arch
        "Architecture": "amd64",

Contrast this to how other images behave:

$ docker pull --platform linux/arm64/v8 k8s.gcr.io/pause:3.5
$ docker inspect k8s.gcr.io/pause:3.5 | grep Arch
        "Architecture": "arm64",

$ docker pull --platform linux/ppc64le k8s.gcr.io/pause:3.5
$ docker inspect k8s.gcr.io/pause:3.5 | grep Arch
        "Architecture": "ppc64le",

What you expected to happen:

The architecture metadata for an image should match its entry in a multi-arch manifest.

Anything else we need to know?:

I haven't checked other images on k8s.gcr.io, but it may be that there are others with this same mistake.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 28, 2021
@serathius
Copy link
Contributor

/help

@k8s-ci-robot
Copy link
Contributor

@serathius:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 2, 2021
Serializator added a commit to Serializator/metrics-server that referenced this issue Nov 3, 2021
Serializator added a commit to Serializator/metrics-server that referenced this issue Nov 3, 2021
Serializator added a commit to Serializator/metrics-server that referenced this issue Nov 3, 2021
@Serializator
Copy link
Contributor

/assign @Serializator

Serializator added a commit to Serializator/metrics-server that referenced this issue Nov 3, 2021
Serializator added a commit to Serializator/metrics-server that referenced this issue Nov 3, 2021
k8s-ci-robot added a commit that referenced this issue Nov 3, 2021
Specify the arch passed as build arg in the distroless image (#848)
serathius added a commit that referenced this issue Nov 16, 2021
[release-0.5] Specify the arch passed as build arg in the distroless image (#848)
serathius added a commit that referenced this issue Nov 16, 2021
[release-0.4] Specify the arch passed as build arg in the distroless image (#848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants