Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Update chart for v0.6.0 #950

Merged

Conversation

stevehipwell
Copy link
Contributor

What this PR does / why we need it:

This PR releases the updated Helm chart for Metrics Server v0.6.0 release from the release branch.

Once this pattern has been proven I'll add some more documentation and controls around chart versioning and releases.

Which issue(s) this PR fixes:
Fixes #938

Signed-off-by: Steve Hipwell steve.hipwell@gmail.com
(cherry picked from commit 5dece1a)

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
(cherry picked from commit 5dece1a)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2022
@yangjunmyfm192085
Copy link
Contributor

yangjunmyfm192085 commented Feb 7, 2022

{{- if .Values.metrics.enabled }}

Is this for Kubernetes versions lower than v1.16 ?
But I remember that the version of v0.6.0 requires kubernetes 1.19+

@stevehipwell
Copy link
Contributor Author

{{- if .Values.metrics.enabled }}

Is this for Kubernetes versions lower than v1.16 ?
But I remember that the version of v0.6.0 requires kubernetes 1.19+

@yangjunmyfm192085 this is based on the discussions on #801 (and other issues) about allowing Prometheus to scrape metrics about Metrics Server.

@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit cb6b586 into kubernetes-sigs:release-0.6 Feb 7, 2022
@stevehipwell stevehipwell deleted the chart-for-v0-6-0 branch February 7, 2022 19:50
@stevehipwell
Copy link
Contributor Author

I'll take a look why the action didn't run from the release branch tomorrow.

@stevehipwell
Copy link
Contributor Author

My chart PR had two commits and I only cherry picked the chart one, I'll open a PR tomorrow to add the CI changes to the release branch.

@stevehipwell
Copy link
Contributor Author

I've opened #954 to add the CI config and release the chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants