add service list to gui #26
Conversation
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/L
Good catch I totally forgot to commit those files, now it should be good |
src/serviceView.cpp
Outdated
| void ServiceView::displayTable(QString svcCmdOutput) | ||
| { | ||
|
|
||
| m_dialog = new QDialog(m_parent); |
There was a problem hiding this comment.
| m_dialog = new QDialog(m_parent); | |
| QDialog dialog = new QDialog(m_parent); |
This doesn't need to be a class wide variable as the variable isn't used outside this function.
|
ready for another look |
| dockerEnvButton->setEnabled(isRunning || isPaused); | ||
| sshButton->setEnabled(isRunning || isPaused); | ||
| mountButton->setEnabled(isRunning || isPaused); | ||
| tunnelButton->setEnabled(isRunning || isPaused); |
There was a problem hiding this comment.
Doesn't have to be done in this PR, but we should make a variable called isRunningOrPaused instead of repeatedly doing isRunning || isPaused
| QLabel *tableLbl = new QLabel(); | ||
| tableLbl->setOpenExternalLinks(true); | ||
| tableLbl->setWordWrap(true); | ||
| tableLbl->setText(svcCmdOutput); |
There was a problem hiding this comment.
Not required, but going forward you can pass a QString to the QLabel constructor and it will pass the QString to setText in the constructor.
There was a problem hiding this comment.
good to know thanks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
can be merged after #24
the gui will need to use json instead of table when this is done kubernetes/minikube#15827