Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add GitHub Action build jobs #29

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

spowelljr
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2023
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2023
Copy link
Contributor

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets choose a more meaningful name for the name of the workflows, this will show up in the github action dasbhoard

so how about maybe

Build Linux
Build macOs
Build Windows

.github/workflows/linux.yml Show resolved Hide resolved
@spowelljr
Copy link
Member Author

lets choose a more meaningful name for the name of the workflows, this will show up in the github action dasbhoard

so how about maybe

Build Linux Build macOs Build Windows

The name of the workflow in the file is what shows up (name: Build Windows) and those are all named as you mentioned. The problem with using build in the file name is that the .gitignore has the following line *build-* so if I named the file build-linux.yml it would be ignored.

@medyagh
Copy link
Contributor

medyagh commented Feb 17, 2023

lets choose a more meaningful name for the name of the workflows, this will show up in the github action dasbhoard
so how about maybe
Build Linux Build macOs Build Windows

The name of the workflow in the file is what shows up (name: Build Windows) and those are all named as you mentioned. The problem with using build in the file name is that the .gitignore has the following line *build-* so if I named the file build-linux.yml it would be ignored.

sounds good, in the future we are gonna have a Release Nightly job, so it will get a bit confusing to update them.

I wonder if we should move all of them to one big workflow (run in parallel) or maybe name them PR but we can also think about it when we add those new jobs

@medyagh medyagh merged commit 5092d0d into kubernetes-sigs:main Feb 17, 2023
@spowelljr spowelljr deleted the addBuildJobs branch September 26, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants