HNC: Delete validation for Namespace and HNS is broken on k8s versions <1.15

[yiqigao217]

See exact same issue in controller-runtime repo - #845.

The HNC webhook validation on kubectl delete ns <namespace> and kubectl delete hns <subnamespace> -n <ownerNamespace> is broken on k8s versions <1.15.

You should get Forbidden:

Error from server (Forbidden): admission webhook "vnamespace.k8s.io" denied the request: The namespace zchild is an owned namespace. Please delete the HNS instance from the owner namespace zparent instead.

instead of BadRequest:

Error from server (BadRequest): admission webhook "vnamespace.k8s.io" denied the request: there is no content to decode

[yiqigao217]

/help
/cc @adrianludwin

[k8s-ci-robot]

@yiqigao217:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/cc @adrianludwin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adrianludwin]

/good-first-issue

I don't think this is very high priority for us to fix (1.14 is on its way out the door anyway, at least on GKE) but if someone wants to help out or we get a strong signal that this fix is needed in 1.14, we can revisit this.

[k8s-ci-robot]

@adrianludwin:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

I don't think this is very high priority for us to fix (1.14 is on its way out the door anyway, at least on GKE) but if someone wants to help out or we get a strong signal that this fix is needed in 1.14, we can revisit this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[adrianludwin]

1.14 is now well out of support so I don't think we need to worry about this.

/remove-lifecycle rotten
/close

[k8s-ci-robot]

@adrianludwin: Closing this issue.

In response to this:

1.14 is now well out of support so I don't think we need to worry about this.

/remove-lifecycle rotten
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.