Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[MTB] Implement Benchmark Lifecycle. #802

Closed
phoenixking25 opened this issue Jun 12, 2020 · 3 comments
Closed

[MTB] Implement Benchmark Lifecycle. #802

phoenixking25 opened this issue Jun 12, 2020 · 3 comments

Comments

@phoenixking25
Copy link
Contributor

Add a Pre-Run or Validate before Run for each Benchmark. Behavior of life-cycle would be like:

  • validate or Pre-Run: if this returns an error the test is marked as "error" instead of "fail".
  • Run: if this returns an error the test is marked as "fail", otherwise "pass".

No need of Post-run at the moment. @JimBugwadia

@phoenixking25
Copy link
Contributor Author

/assign @Divya063

@k8s-ci-robot
Copy link
Contributor

@phoenixking25: GitHub didn't allow me to assign the following users: Divya063.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Divya063

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@phoenixking25
Copy link
Contributor Author

Merged #811

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants