Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[MTB] added readme #812

Merged
merged 7 commits into from
Jul 7, 2020
Merged

[MTB] added readme #812

merged 7 commits into from
Jul 7, 2020

Conversation

phoenixking25
Copy link
Contributor

/assign @JimBugwadia
Added basic info and commands to build the project.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @phoenixking25. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 18, 2020
@JimBugwadia
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2020
JimBugwadia
JimBugwadia suggested changes Jun 18, 2020
View reviewed changes
benchmarks/kubectl-mtb/README.md Outdated

### Make commands

- **make kubectl** : To build the project and copy the binary file to the PATH.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would suggest we call this "make mtb" or "make kubectl-mtb" to avoid confusion with kubectl.

@JimBugwadia
Copy link
Contributor

Same comment on these folders:

https://github.com/kubernetes-sigs/multi-tenancy/tree/master/benchmarks/kubectl-mtb/cmd/kubectl

https://github.com/kubernetes-sigs/multi-tenancy/tree/master/benchmarks/kubectl-mtb/internal/kubectl

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2020
@rjbez17
Copy link

rjbez17 commented Jul 6, 2020

/hold

until comments addressed

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 6, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@JimBugwadia
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JimBugwadia, phoenixking25

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@JimBugwadia
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 7, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2020
@JimBugwadia
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit a83c30e into kubernetes-retired:master Jul 7, 2020
@phoenixking25 phoenixking25 mentioned this pull request Aug 23, 2020
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JimBugwadia JimBugwadia JimBugwadia approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

Assignees

@JimBugwadia JimBugwadia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phoenixking25 @k8s-ci-robot @JimBugwadia @rjbez17