Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[MTB]Added Remaining benchmarks #880

Merged
merged 4 commits into from
Jul 23, 2020
Merged

[MTB]Added Remaining benchmarks #880

merged 4 commits into from
Jul 23, 2020

Conversation

Divya063
Copy link
Contributor

@Divya063 Divya063 commented Jul 13, 2020 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Divya063. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2020
@Divya063
Copy link
Contributor Author

/assign @JimBugwadia

@Divya063 Divya063 changed the title Added Remaining benchmarks [MTB]Added Remaining benchmarks Jul 13, 2020
phoenixking25
phoenixking25 reviewed Jul 13, 2020
View reviewed changes
benchmarks/kubectl-mtb/test/benchmarks/configure_ns_quotas/configure_ns_quotas.go Outdated Show resolved Hide resolved
benchmarks/kubectl-mtb/test/benchmarks/configure_ns_quotas/configure_ns_quotas.go Outdated
"sigs.k8s.io/multi-tenancy/benchmarks/kubectl-mtb/test/utils"
)

func getResourceNameList(tclient *kubernetes.Clientset) ([]string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Divya063 Using nodes for retrieving resource list is not a good idea here because it contains more resources that we dont have to check like hugepages. We can go with pre-set resource list and giving user feature to add their own resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimBugwadia Would it be okay if we ask the user to pass their own resource list via CLI or a YAML file?

@Divya063 Divya063 changed the title [MTB]Added Remaining benchmarks [WIP][MTB]Added Remaining benchmarks Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2020
@JimBugwadia
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2020
@JimBugwadia
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 20, 2020
@Divya063 Divya063 changed the title [WIP][MTB]Added Remaining benchmarks [MTB]Added Remaining benchmarks Jul 20, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2020
@JimBugwadia
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Divya063, JimBugwadia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 73874e2 into kubernetes-retired:master Jul 23, 2020
@phoenixking25 phoenixking25 mentioned this pull request Aug 23, 2020
Closed
6 tasks
@Divya063 Divya063 mentioned this pull request Aug 24, 2020
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phoenixking25 phoenixking25 phoenixking25 left review comments

@JimBugwadia JimBugwadia JimBugwadia approved these changes

@srampal srampal Awaiting requested review from srampal

@tashimi tashimi Awaiting requested review from tashimi

Assignees

@JimBugwadia JimBugwadia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Divya063 @k8s-ci-robot @JimBugwadia @phoenixking25