Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shellcheck verification step to makefile #181

Merged
merged 3 commits into from
Feb 15, 2024
Merged

add shellcheck verification step to makefile #181

merged 3 commits into from
Feb 15, 2024

Conversation

gabrielggg
Copy link
Contributor

Hi.

This is to resolve #94

This install.sh file is a script i created to simplify the instalation of shellcheck, it is a fork from this script https://github.com/golangci/golangci-lint/blob/master/install.sh which is used on the verify-golint.sh script from this repo. If you want i can upload that script also here, now it is hosted on my personal repo.

I took the same approach you used on #37 creating a verify-shellcheck.sh script so that it gets automatically included on the ci pipeline because of the hack/verify-all.sh script wildcard usage.

p.s. This is my first PR to a kubernetes project, so i hope everything goes well.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 25, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify Netlify
Copy link

netlify bot commented Nov 25, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit 534d923
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/65cd669e665f8c000888a1bd
😎 Deploy Preview https://deploy-preview-181--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 25, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @gabrielggg!

It looks like this is your first PR to kubernetes-sigs/network-policy-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/network-policy-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @gabrielggg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 25, 2023
@astoycos
Copy link
Member

/ok-to-test

Thanks for your first PR!! @gabrielggg I'll review today

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2023
astoycos
astoycos requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this, one main comment below!

hack/verify-shellcheck.sh Outdated Show resolved Hide resolved
astoycos
astoycos reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now @gabrielggg Can you now just fix all the scripts up in a new commit so that the new test passes?

Also please squash these commits before doing so

@gabrielggg gabrielggg closed this Dec 4, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2023
@gabrielggg gabrielggg reopened this Dec 4, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@astoycos
Copy link
Member

astoycos commented Jan 8, 2024

Looks pretty much there!! Can you rebase please?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2024
@gabrielggg
Copy link
Contributor Author

Done with the rebase @astoycos

@astoycos
Copy link
Member

/retest

@astoycos
Copy link
Member

Hiya @gabrielggg!!! Will you have a chance to finish this up and get CI passing? Looks like there's still some things failing verification and you'll need to sign the K8s CLA

@astoycos
Copy link
Member

Additionally please try and signoff your commits :)

@gabrielggg
Copy link
Contributor Author

/retest

@gabrielggg
Copy link
Contributor Author

Hey @astoycos , i fixed the last failing tests and signed the K8s CLA, but for some reason, it still saying missing authorization on the EasyCLA item of the pipeline, can you please check that out?

@astoycos
Copy link
Member

/check-cla

1 similar comment
@astoycos
Copy link
Member

/check-cla

@astoycos
Copy link
Member

Hrm not sure why the CLA isn't re-checking 🤔

@astoycos
Copy link
Member

/easycla

@astoycos
Copy link
Member

@gabrielggg Thanks for the update!! I'm thinking you may need to sign your commits with the same email used for the CLA verification?

Additionally it looks like you used different git accounts during the process and that may be messing things up

Gomez authored and Gabriel Fernando Gomez De La Torres Parod committed

It should look something like

image

@gabrielggg
squash shellcheck verification files
fac725f 
Signed-off-by: Gabriel Gomezdelatorre <gabriel.gomezdelatorre@hotmail.com>
@gabrielggg
fixing shellcheck linting errors, warnings and recommendations
934bafa 
Signed-off-by: Gabriel Gomezdelatorre <gabriel.gomezdelatorre@hotmail.com>
@gabrielggg
fix some shellcheck errors
534d923 
Signed-off-by: Gabriel Gomezdelatorre <gabriel.gomezdelatorre@hotmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 15, 2024
@gabrielggg
Copy link
Contributor Author

hey @astoycos , thanks for the advice, i did that and know i think we are ready to go!

astoycos
astoycos approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Congrats on your first commit @gabrielggg and thanks very much!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, gabrielggg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 06d584d into kubernetes-sigs:main Feb 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astoycos astoycos astoycos approved these changes

@Dyanngg Dyanngg Awaiting requested review from Dyanngg

Assignees

@astoycos astoycos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Script linter to our CI workflow
3 participants
@gabrielggg @k8s-ci-robot @astoycos