Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Execution on Fedora 36 and Kubernetes v1.24.3 #109

Merged
merged 6 commits into from Jan 20, 2023

Conversation

modzilla99
Copy link
Contributor

With Fedora CoreOS 36 and Kubernetes v1.24.3 the container hangs in a CrashLoopBackoff and has to be OOM-killed by the kernel.

With a rebase on F36 and the latest ganesha, the problem is gone.

Signed-off-by: Justin Lamp <justin.lamp@netways.de>
Signed-off-by: Justin Lamp <justin.lamp@netways.de>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 16, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 16, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @modzilla99!

It looks like this is your first PR to kubernetes-sigs/nfs-ganesha-server-and-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-ganesha-server-and-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 16, 2022
Signed-off-by: Justin Lamp <justin.lamp@netways.de>
@modzilla99
Copy link
Contributor Author

@kvaps sorry for pinging you, but any chance of this (or sth similar) getting merged?

Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution and sorry for late reply, changes looks good.
Could you update chart version from 1.5.0 to 1.6.0?

@wigust
Copy link

wigust commented Jan 14, 2023

Hi @kvaps , @modzilla99 .

Without this patch the nfs-ganesha will be OOMKilled installed with the latest helm chart.

I've tested modzilla99:master by installing it in a cluster and running a pod with a mounted NFS share. Everything works smoothly. Could we merge it faster to avoid manual container build and make the installation easier?

I could fork and apply required chart version change and create a new pull request if needed.

Signed-off-by: Justin Lamp <justin.lamp@netways.de>
@modzilla99
Copy link
Contributor Author

modzilla99 commented Jan 18, 2023

Hey,

I rebased and bumped the version to v1.6.0. Please tell me if I missed sth!

/assign @kvaps

Best regards,
modzilla

Signed-off-by: Justin Lamp <justin.lamp@netways.de>
@modzilla99
Copy link
Contributor Author

Without this patch the nfs-ganesha will be OOMKilled installed with the latest helm chart.

I found that the problem was caused by a bad ulimit setting. If you change the cri base spec and set the ulimit to something smaller it will fix it (and mysql:5.7 as well).

$ ctr oci spec | jq '.process.rlimits[0].soft=262144 | .process.rlimits[0].hard=524288' > /etc/containerd/cri-base.json
$ tail -n5 /etc/containerd/config.toml
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
  # set default runtime handler to v2, which has a per-pod shim
  runtime_type = "io.containerd.runc.v2"
  # Generated by "ctr oci spec" and modified ulimits to fix OOMKills
  base_runtime_spec = "/etc/containerd/cri-base.json"

Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvaps, modzilla99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@modzilla99
Copy link
Contributor Author

Great! Can you add the lgtm label or does @ashishranjan738 need to do that?

@kvaps
Copy link
Member

kvaps commented Jan 20, 2023

Yeah, I just waited for other PRs be merged,

/lgtm thank you

@kvaps
Copy link
Member

kvaps commented Jan 20, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit ced97dc into kubernetes-sigs:master Jan 20, 2023
@@ -8,7 +8,7 @@ replicaCount: 1

image:
repository: k8s.gcr.io/sig-storage/nfs-provisioner
tag: v3.0.0
tag: v4.0.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skopeo list-tags docker://k8s.gcr.io/sig-storage/nfs-provisioner
{
    "Repository": "k8s.gcr.io/sig-storage/nfs-provisioner",
    "Tags": [
        "v2.2.2",
        "v3.0.0",
        "v3.0.1"
    ]
}

#115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants