Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use podLabels with user defined labels in deployment pod template #100

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

yonatankahana
Copy link
Contributor

PR #72 adds the ability to specify labels for all objects created but it does not allow to control the deployment's pods labels which is sometimes important.
we can't just use nfs-subdir-external-provisioner.labels because it contains version information and will force redeployment every chart upgrade. instead, we will use nfs-subdir-external-provisioner.podLabels which consist of nfs-subdir-external-provisioner.selectorLabels and user defined labels.

Fixes #63
/cc @mkilchhofer
/cc @kmova
/assign @kmova

@k8s-ci-robot
Copy link
Contributor

@yonatankahana: GitHub didn't allow me to request PR reviews from the following users: mkilchhofer.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

PR #72 adds the ability to specify labels for all objects created but it does not allow to control the deployment's pods labels which is sometimes important.
we can't just use nfs-subdir-external-provisioner.labels because it contains version information and will force redeployment every chart upgrade. instead, we will use nfs-subdir-external-provisioner.podLabels which consist of nfs-subdir-external-provisioner.selectorLabels and user defined labels.

Fixes #63
/cc @mkilchhofer
/cc @kmova
/assign @kmova

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2021
@yonatankahana yonatankahana marked this pull request as draft May 13, 2021 18:02
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2021
Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
@yonatankahana yonatankahana marked this pull request as ready for review May 13, 2021 18:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2021
Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
Copy link
Contributor

@kmova kmova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmova, yonatankahana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kmova,yonatankahana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c0dd02 into kubernetes-sigs:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: add support to customize the labels and annotations for the resources (deployment, pod, etc)
3 participants