Use podLabels with user defined labels in deployment pod template #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #72 adds the ability to specify labels for all objects created but it does not allow to control the deployment's pods labels which is sometimes important.
we can't just use
nfs-subdir-external-provisioner.labels
because it contains version information and will force redeployment every chart upgrade. instead, we will usenfs-subdir-external-provisioner.podLabels
which consist ofnfs-subdir-external-provisioner.selectorLabels
and user defined labels.Fixes #63
/cc @mkilchhofer
/cc @kmova
/assign @kmova