Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies to latest version #258

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/nfs-subdir-external-provisioner/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
apiVersion: v1
appVersion: 4.0.2
appVersion: 4.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only version should be bumped, appVersion is the image tag (4.0.2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was deliberate , so that, the image ( tag) remain consistent for older deployment.. the upgrade can be version and image update to really land on new versions. @yonatankahana .

description: nfs-subdir-external-provisioner is an automatic provisioner that used your *already configured* NFS server, automatically creating Persistent Volumes.
name: nfs-subdir-external-provisioner
home: https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner
version: 4.0.19
kubeVersion: ">=1.9.0-0"
version: 4.0.20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the version will cause chart release, better to change the kubeVersion only when we will actually release the chart with those restrictions, currently it will be redundant since image and chart are same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new chart release was the plan with new image tag as mentioned above. so that the versions remain different and users can upgrade when they want.

kubeVersion: ">=1.21.0-0"
sources:
- https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner
keywords:
Expand Down
2 changes: 1 addition & 1 deletion charts/nfs-subdir-external-provisioner/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This charts installs custom [storage class](https://kubernetes.io/docs/concepts/

## Prerequisites

- Kubernetes >=1.9
- Kubernetes >=1.21
- Existing NFS Share

## Installing the Chart
Expand Down
Loading