Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump helm chart to 4.0.3 #61

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

yonatankahana
Copy link
Contributor

@yonatankahana yonatankahana commented Mar 3, 2021

we forgot to bump the version in #56 but we modified the chart and caused build failure.

Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2021
@yonatankahana
Copy link
Contributor Author

yonatankahana commented Mar 3, 2021

/approve
/lgtm

edit:
😄

@k8s-ci-robot
Copy link
Contributor

@yonatankahana: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@james-d-elliott
Copy link

The ct lint command can be configured to fail when the chart is changed and not version bumped to prevent a merge like this. Example:

https://github.com/authelia/chartrepo/blob/master/.buildkite/ct.yaml#L5

Also looks like there is an action: https://github.com/helm/chart-testing-action

@FernandoMorais
Copy link

Hi guys!
Some update on this? This change is exactly what I need here. LOL

@yonatankahana
Copy link
Contributor Author

The ct lint command can be configured to fail when the chart is changed and not version bumped to prevent a merge like this. Example:

https://github.com/authelia/chartrepo/blob/master/.buildkite/ct.yaml#L5

Also looks like there is an action: https://github.com/helm/chart-testing-action

good idea that can prevent such mistakes. follow #66

@kmova
Copy link
Contributor

kmova commented Mar 5, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmova, yonatankahana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit f491425 into kubernetes-sigs:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants