-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump helm chart to 4.0.3 #61
Bump helm chart to 4.0.3 #61
Conversation
Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
/approve edit: |
@yonatankahana: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The ct lint command can be configured to fail when the chart is changed and not version bumped to prevent a merge like this. Example: https://github.com/authelia/chartrepo/blob/master/.buildkite/ct.yaml#L5 Also looks like there is an action: https://github.com/helm/chart-testing-action |
Hi guys! |
good idea that can prevent such mistakes. follow #66 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kmova, yonatankahana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
we forgot to bump the version in #56 but we modified the chart and caused build failure.