Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PV provisioning fails when storageclass has volumeBindingMode as 'WaitForFirstConsumer' #71

Conversation

khalsa-ji
Copy link
Contributor

Fixes #70 :

  1. Adds RBAC permissions to get nodes in the cluster.
  2. Bumps chart version.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @khalsa-ji!

It looks like this is your first PR to kubernetes-sigs/nfs-subdir-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-subdir-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2021
@khalsa-ji khalsa-ji force-pushed the bugfix/provisioningFails-storageclassWith-WaitForFirstConsumer branch from d84b23e to d9e0f24 Compare March 10, 2021 05:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 10, 2021
@khalsa-ji khalsa-ji force-pushed the bugfix/provisioningFails-storageclassWith-WaitForFirstConsumer branch from d9e0f24 to a4bedf8 Compare March 10, 2021 06:17
@khalsa-ji
Copy link
Contributor Author

/assign @kmova

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2021
@khalsa-ji khalsa-ji force-pushed the bugfix/provisioningFails-storageclassWith-WaitForFirstConsumer branch from a4bedf8 to 1486b69 Compare April 8, 2021 04:23
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2021
…tForFirstConsumer':

1. Adds RBAC permissions to get nodes in the cluster.
2. Bumps the chart version
@khalsa-ji khalsa-ji force-pushed the bugfix/provisioningFails-storageclassWith-WaitForFirstConsumer branch from 1486b69 to 2cad8da Compare April 28, 2021 07:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khalsa-ji, yonatankahana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@yonatankahana
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit ae50b6d into kubernetes-sigs:master Apr 29, 2021
@yonatankahana
Copy link
Contributor

thank you for your contribution :)

@khalsa-ji khalsa-ji deleted the bugfix/provisioningFails-storageclassWith-WaitForFirstConsumer branch April 30, 2021 17:28
@khalsa-ji
Copy link
Contributor Author

thank you for your contribution :)

It is my pleasure to contribute to the project. :)
@yonatankahana : Thank you for reviewing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PV provisioning fails for storageclass with volumeBindingMode as 'WaitForFirstConsumer'
4 participants