Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.1 #76

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

yonatankahana
Copy link
Contributor

@yonatankahana yonatankahana commented Mar 17, 2021

all work related to release version 4.0.1

Changes:

Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2021
@yonatankahana
Copy link
Contributor Author

/assign @kmova

@kmova
Copy link
Contributor

kmova commented Mar 24, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmova, yonatankahana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kmova,yonatankahana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 522d8f8 into kubernetes-sigs:master Mar 24, 2021
@geoff-coppertop
Copy link

It doesn't look like the 32-bit arm image was built when I check 4.01 gcr.io/k8s-staging-sig-storage/nfs-subdir-external-provisioner

@yonatankahana
Copy link
Contributor Author

It doesn't look like the 32-bit arm image was built when I check 4.01 gcr.io/k8s-staging-sig-storage/nfs-subdir-external-provisioner

cc @kmova
plus, we merged #68 therefore the chart version should be bumped here before we merged. ill open new PR to fix the chart version but first we need to fix the image with arm32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants