Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: make golangci-lint runnable in verify.sh #21

Merged
merged 1 commit into from Sep 17, 2020
Merged

scripts: make golangci-lint runnable in verify.sh #21

merged 1 commit into from Sep 17, 2020

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 17, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2020
ArangoGutierrez
ArangoGutierrez approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#23
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2020
@ArangoGutierrez
Copy link
Contributor

is runnable, not... happy tho

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2020
@ArangoGutierrez
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit a4ff93f into kubernetes-sigs:master Sep 17, 2020
@marquiz marquiz deleted the devel/scripts branch September 17, 2020 18:06
courtneypacheco pushed a commit to courtneypacheco/node-feature-discovery-operator that referenced this pull request May 20, 2021
@psap-ci-robot
Merge pull request kubernetes-sigs#21 from openshift/deployment-fix
581995c 
During deployment and sed replacing the namespace two manifests were …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marquiz @k8s-ci-robot @ArangoGutierrez