Skip to content

Commit

Permalink
scripts/test-infra: add logcheck to verify script
Browse files Browse the repository at this point in the history
Now that we've migrated to structured logging add a verification step to
verify that future additions/changes to logging comply.
  • Loading branch information
marquiz committed May 31, 2023
1 parent 2331b0f commit 01525de
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions scripts/test-infra/logcheck.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
-structured sigs.k8s.io/node-feature-discovery/pkg/utils/grpc_log.go
7 changes: 7 additions & 0 deletions scripts/test-infra/verify.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/bin/bash -e

this_dir=`dirname $0`

# Install deps
gobinpath="$(go env GOPATH)/bin"
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b "$gobinpath" v1.52.2
Expand All @@ -15,6 +17,8 @@ curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring
curl -Os https://uploader.codecov.io/latest/linux/codecov
chmod +x codecov

go install sigs.k8s.io/logtools/logcheck@v0.5.0

# Run verify steps
echo "Checking gofmt"
make gofmt-verify
Expand All @@ -25,6 +29,9 @@ make ci-lint
echo "Running Helm lint"
make helm-lint

echo "Running logcheck"
logcheck -config "${this_dir}/logcheck.conf" ./cmd/... ./pkg/... ./source/...

echo "Running unit tests"
make test

Expand Down

0 comments on commit 01525de

Please sign in to comment.