Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kustomize templates #1241

Closed
ArangoGutierrez opened this issue Jun 5, 2023 · 7 comments · Fixed by #1246
Closed

Update kustomize templates #1241

ArangoGutierrez opened this issue Jun 5, 2023 · 7 comments · Fixed by #1246
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ArangoGutierrez
Copy link
Contributor

What would you like to be added:
When running make deploy with a latest (devel) version

[eduardo@fedora node-feature-discovery]$ kustomize version
(devel)

A warning of deprecation is showing for NFD templates

Why is this needed:

kubectl apply -k .
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
@ArangoGutierrez ArangoGutierrez added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 5, 2023
@fmuyassarov
Copy link
Member

Yes, we basically need to move for example - ../../base/rbac under

to be under . And same changes on the other kustomization files.

@marquiz
Copy link
Contributor

marquiz commented Jun 6, 2023

Yeah, should be trivial to fix
/help

@k8s-ci-robot
Copy link
Contributor

@marquiz:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Yeah, should be trivial to fix
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 6, 2023
@dipankardas011
Copy link
Contributor

@marquiz can I try to fix it?

@ArangoGutierrez
Copy link
Contributor Author

@dipankardas011 sure! we would help you along the way with reviews, go ahead! thanks for contributing!

@marquiz
Copy link
Contributor

marquiz commented Jun 8, 2023

can I try to fix it?

@dipankardas011 yeah, sure

dipankardas011 added a commit to dipankardas011/node-feature-discovery that referenced this issue Jun 8, 2023
Closes kubernetes-sigs#1241

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
@dipankardas011
Copy link
Contributor

Created the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants