Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version string from published label key #24

Closed
ConnorDoyle opened this issue Oct 25, 2016 · 0 comments
Closed

Remove version string from published label key #24

ConnorDoyle opened this issue Oct 25, 2016 · 0 comments
Assignees
@ConnorDoyle
Milestone
v0.1.0

Comments

@ConnorDoyle
Copy link
Contributor

There has been feedback from many people that including the version in the published label is bad because it causes affinity annotations in pod specs to be invalidated upon upgrading the version of node-feature-discovery.
@ConnorDoyle ConnorDoyle self-assigned this Oct 25, 2016
@ConnorDoyle ConnorDoyle modified the milestone: v0.1.0 Oct 25, 2016
@ConnorDoyle ConnorDoyle mentioned this issue Oct 25, 2016
Merged
nfd-merge-bot added a commit that referenced this issue Oct 26, 2016
@nfd-merge-bot
Merge pull request #28 from ConnorDoyle/rm-version-from-keys
be5a271 
Automatic merge from submit-queue

Removed version from published label keys.

Fixes #24
@ConnorDoyle ConnorDoyle mentioned this issue Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ConnorDoyle ConnorDoyle

Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
1 participant
@ConnorDoyle