Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: refactor matching of node properties #1184

Merged
merged 4 commits into from
May 5, 2023
Merged

test/e2e: refactor matching of node properties #1184

merged 4 commits into from
May 5, 2023

Commits on May 3, 2023

  1. test/e2e: refactor matching of node properties 

    Implement a new generic type nodeListPropertyMatcher, a generic Gomega
matcher for matching basically any property of a set of node objects. We
will be using it for verifying labels, annotations, extended resources
and taints for now. This moves the tests in a more Gomega'ish direction,
leveraging code re-use and providing way more informative error messages
in case of test failures.

The patch adds a new eventuallyNonControlPlaneNodes helper assertion for
asserting all (non-control-plane) nodes in the cluster, intended to
replace the ugly simplePoll() helper function.

This patch implements a matcher for node labels and converts tests to
use it instead of the old checkForNodeLabels helper function.
    @marquiz
    marquiz committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2330896 View commit details
    Browse the repository at this point in the history

  2. test/e2e: rework annotations matcher 

    Add new MatchAnnotations Gomega matcher and drop the old
waitForNfdNodeAnnotations helper function.
    @marquiz
    marquiz committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a85e396 View commit details
    Browse the repository at this point in the history

  3. test/e2e: rework node capacity matching 

    Add new MatchCapacity matcher replacing the old waitForCapacity helper
function.
    @marquiz
    marquiz committed May 3, 2023
    Configuration menu
    Copy the full SHA
    f93ab9d View commit details
    Browse the repository at this point in the history

  4. test/e2e: rework taints matching 

    Add new MatchTaints matcher replacing the old waitForNfdNodeTaints
helper function. Also, drop the now-unused simplePoll() helper function.
    @marquiz
    marquiz committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2d9db2c View commit details
    Browse the repository at this point in the history