Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/test-infra: add logcheck to verify script #1235

Merged
merged 1 commit into from
May 31, 2023
Merged

scripts/test-infra: add logcheck to verify script #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/test-infra/logcheck.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
-structured sigs.k8s.io/node-feature-discovery/pkg/utils/grpc_log.go
7 changes: 7 additions & 0 deletions scripts/test-infra/verify.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/bin/bash -e

this_dir=`dirname $0`

# Install deps
gobinpath="$(go env GOPATH)/bin"
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b "$gobinpath" v1.52.2
Expand All @@ -15,6 +17,8 @@ curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring
curl -Os https://uploader.codecov.io/latest/linux/codecov
chmod +x codecov

go install sigs.k8s.io/logtools/logcheck@v0.5.0

# Run verify steps
echo "Checking gofmt"
make gofmt-verify
Expand All @@ -25,6 +29,9 @@ make ci-lint
echo "Running Helm lint"
make helm-lint

echo "Running logcheck"
logcheck -config "${this_dir}/logcheck.conf" ./cmd/... ./pkg/... ./source/...

echo "Running unit tests"
make test

Expand Down