Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: prevent parallel runs of gh-pages update #1358

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 15, 2023

Ensure sequential updates to the gh-pages branch. Otherwise, if parallel jobs are triggered, onnly one (the first to complete) will succeed and the others will fail with git push error (because the tip of the gh-pages has moved and their commit doesn't apply anymore).

Ensure sequential updates to the gh-pages branch. Otherwise, if parallel
jobs are triggered, onnly one (the first to complete) will succeed and
the others will fail with git push error (because the tip of the
gh-pages has moved and their commit doesn't apply anymore).
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit ef3ad8f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/65041d75dac44a000881e93e
😎 Deploy Preview https://deploy-preview-1358--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Sep 15, 2023

/assign @fmuyassarov

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2023
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ddc78df873e4942f3a4dfb0efd1ef398ca744395

@k8s-ci-robot k8s-ci-robot merged commit 45cc1cf into kubernetes-sigs:master Sep 15, 2023
7 checks passed
@marquiz marquiz deleted the devel/github-release-workflow-concurrency branch September 15, 2023 12:51
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants