Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment/helm: fix namespace of nfd-worker role and rolebinding #1364

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 19, 2023

Put nfd-worker role and rolebinding in the correct namespace if namespaceOverride parameter is used.

Fixes: #1363

Put nfd-worker role and rolebinding in the correct namespace if
namespaceOverride parameter is used.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2023
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 759143e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6509810f142d340008dec9e5
😎 Deploy Preview https://deploy-preview-1364--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Sep 19, 2023

/cherry-pick release-0.13

@k8s-infra-cherrypick-robot

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1364 (759143e) into master (2ea6d03) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1364   +/-   ##
=======================================
  Coverage   30.02%   30.02%           
=======================================
  Files          56       56           
  Lines        7457     7457           
=======================================
  Hits         2239     2239           
  Misses       4974     4974           
  Partials      244      244           

@marquiz
Copy link
Contributor Author

marquiz commented Sep 19, 2023

/cherry-pick release-0.14
/assign @ArangoGutierrez

@k8s-infra-cherrypick-robot

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.14
/assign @ArangoGutierrez

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jjacobelli
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7115370e0b06153b7f0fded80c5af528a7d58a10

@k8s-ci-robot k8s-ci-robot merged commit 3a21f2f into kubernetes-sigs:master Sep 19, 2023
9 checks passed
@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #1369

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #1370

In response to this:

/cherry-pick release-0.14
/assign @ArangoGutierrez

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz marquiz deleted the devel/helm-fix-ns branch September 19, 2023 12:06
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm: worker role&rolebinding doesn't respect namespaceOverride
5 participants