Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support raw features #1386

Merged

Conversation

AhmedGrati
Copy link

Resolves #1376.

Note: I used no-label and no-feature directives instead of noLabel and noFeature, to make it consistent with expiry-time directive.

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 3130898
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/651ddb2e510d900008f7d8d9
😎 Deploy Preview https://deploy-preview-1386--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2023
@AhmedGrati
Copy link
Author

AhmedGrati commented Oct 2, 2023

/cc @marquiz @ArangoGutierrez
ping @tkatila

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhmedGrati. Some really quick comments below. We also need to update the documentation (at least docs/usage/customization-guide.md) to mention the new directives and the new local.features feature.

/cc @tkatila @eero-t

source/local/local.go Show resolved Hide resolved
source/local/local.go Outdated Show resolved Hide resolved
source/local/local.go Outdated Show resolved Hide resolved
source/local/local.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@marquiz: GitHub didn't allow me to request PR reviews from the following users: tkatila, eero-t.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks @AhmedGrati. Some really quick comments below. We also need to update the documentation (at least docs/usage/customization-guide.md) to mention the new directives and the new local.features feature.

/cc @tkatila @eero-t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update also to test code and docs would be good.

source/local/local.go Outdated Show resolved Hide resolved
@AhmedGrati AhmedGrati force-pushed the feat-support-raw-features branch 3 times, most recently from 0bae460 to 128c97a Compare October 3, 2023 17:25
docs/usage/customization-guide.md Outdated Show resolved Hide resolved
source/local/local.go Outdated Show resolved Hide resolved
source/local/local.go Outdated Show resolved Hide resolved
docs/usage/customization-guide.md Outdated Show resolved Hide resolved
@AhmedGrati AhmedGrati force-pushed the feat-support-raw-features branch 2 times, most recently from c0a125f to d0703a7 Compare October 4, 2023 16:56
docs/usage/customization-guide.md Outdated Show resolved Hide resolved
docs/usage/customization-guide.md Show resolved Hide resolved
source/local/local.go Outdated Show resolved Hide resolved
@AhmedGrati AhmedGrati force-pushed the feat-support-raw-features branch 2 times, most recently from 37c3230 to 8f67f11 Compare October 4, 2023 21:35
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks @AhmedGrati for the contribution. I think @tkatila et al will be happy 😊
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d686c6b8143c4c8d5848cc9a25acb9ec1ae9a3b9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1386 (3130898) into master (076ed3c) will increase coverage by 0.11%.
Report is 3 commits behind head on master.
The diff coverage is 48.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
+ Coverage   30.02%   30.14%   +0.11%     
==========================================
  Files          56       56              
  Lines        7457     7497      +40     
==========================================
+ Hits         2239     2260      +21     
- Misses       4974     4991      +17     
- Partials      244      246       +2     
Files Coverage Δ
source/local/local.go 46.71% <48.57%> (+1.05%) ⬆️

@k8s-ci-robot k8s-ci-robot merged commit 4b3429d into kubernetes-sigs:master Oct 5, 2023
14 checks passed
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels converted to resources are also kept also as labels
5 participants