Helm - service to be only deployed when needed #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
approved
|
/assign @marquiz |
marquiz
reviewed
Oct 4, 2023
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
approved these changes
Oct 4, 2023
k8s-ci-robot
added
tide/merge-method-squash
|
LGTM label has been added. Git tree hash: b0e6b8ddedfc768fd9045f8b0d89d6d6178bd07d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1389 +/- ##
=======================================
Coverage 30.02% 30.02%
=======================================
Files 56 56
Lines 7457 7457
=======================================
Hits 2239 2239
Misses 4974 4974
Partials 244 244 |
cruizen
pushed a commit
to platform9/node-feature-discovery
that referenced
this pull request
Mar 12, 2024
* Helm - service to be only deployed when needed Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> * Update deployment/helm/node-feature-discovery/templates/service.yaml Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com> --------- Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.