Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serviceaccount handling for nfd-gc to be consistent with others #1392

Merged

Conversation

shivamerla
Copy link
Contributor

No description provided.

Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: shivamerla / name: Shiva Krishna Merla (6237b82)

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 6237b82
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/651de513d6ce620008be30a7
😎 Deploy Preview https://deploy-preview-1392--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @shivamerla!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @shivamerla. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 4, 2023
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shivamerla for the fix. Looks good!

Could you sign the CLA so that we can get this merged?

/lgtm
/cherry-pick release-0.14

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 84eae1b922f0842016279b994ced422bd8a8efac

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, shivamerla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@marquiz
Copy link
Contributor

marquiz commented Oct 5, 2023

Could you sign the CLA so that we can get this merged?

Sorry @shivamerla I was looking some unfreshed page of this 🙈 CLA is fine

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1392 (6237b82) into master (dd8d7f6) will increase coverage by 0.11%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
+ Coverage   30.02%   30.14%   +0.11%     
==========================================
  Files          56       56              
  Lines        7457     7497      +40     
==========================================
+ Hits         2239     2260      +21     
- Misses       4974     4991      +17     
- Partials      244      246       +2     

see 1 file with indirect coverage changes

@k8s-ci-robot k8s-ci-robot merged commit 7f6fd05 into kubernetes-sigs:master Oct 5, 2023
9 checks passed
@ArangoGutierrez
Copy link
Contributor

/cherry-pick release-0.14

@k8s-infra-cherrypick-robot

@ArangoGutierrez: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/cherry-pick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants