feat: discover virtual network interface

[AhmedGrati]

Resolves #1385.

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	6aa6590
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/654cfe6754bd240008b7bf54
😎 Deploy Preview	https://deploy-preview-1448--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[AhmedGrati]

/cc @marquiz

[marquiz]

Thanks @AhmedGrati for this enhancement. I will review it in detail in the near future

ping @rwlove

[rwlove]

Would you be able to get the VLAN ID from the interface with this change?

[AhmedGrati]

@rwlove currently no, but I think we can add it. wdyt @marquiz?

[marquiz]

@rwlove currently no, but I think we can add it. wdyt @marquiz?

Sure, if it's somehow possible to get that information (in our limited environment). Otherwise you just need to e.g. rely in naming of your interfaces

[AhmedGrati]

@marquiz We need to add another mount-point which is /proc/net/vlan in order to get the VLAN ID of a specific network interface.

[marquiz]

We need to add another mount-point which is /proc/net/vlan in order to get the VLAN ID of a specific network interface.

Hmm, I don't like that. Plus reading it needs root?

[AhmedGrati]

@marquiz reading doesn't require root access.

[AhmedGrati]

/retest

[AhmedGrati]

ping @marquiz

[marquiz]

From my side this looks ready to get in

[marquiz]

@marquiz reading doesn't require root access.

At least with all the distros I tried (Ubuntu, Fedora, openSUSE) it requires root

$ ls /proc/net/vlan/ -l
total 0
-rw------- 1 root root 0 Nov  9 21:13 config
-rw------- 1 root root 0 Nov  9 21:13 eno2.12

[AhmedGrati]

@marquiz should you assign the merging to someone?

[marquiz]

/assign @ArangoGutierrez

[AhmedGrati]

ping @ArangoGutierrez

[AhmedGrati]

ping @ArangoGutierrez

[ArangoGutierrez]

ping @ArangoGutierrez

Sorry I was a bit focused on a new feature, will review this today

[ArangoGutierrez]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e81e6ca2f16bfea86d45dcb2785422e987bf3ec7

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #1448 (6aa6590) into master (536a006) will increase coverage by 2.80%.
Report is 50 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   30.55%   33.35%   +2.80%     
==========================================
  Files          58       58              
  Lines        7527     7956     +429     
==========================================
+ Hits         2300     2654     +354     
- Misses       4978     5021      +43     
- Partials      249      281      +32     

Files	Coverage Δ
source/network/network.go	18.30% <0.00%> (-0.81%)	⬇️

... and 5 files with indirect coverage changes