Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment/kustomize: drop nfd-master service #1494

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 8, 2023

Not needed anymore as we're not relying on gRPC anymore.

Not needed anymore as we're not relying on gRPC anymore.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2023
Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 9624d18
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/65731203ef7d4f000881d3af
😎 Deploy Preview https://deploy-preview-1494--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2023
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ed369a34685eb9508f67cec0a61608571b70557

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #1494 (9624d18) into master (7f859ce) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1494   +/-   ##
=======================================
  Coverage   30.74%   30.74%           
=======================================
  Files          58       58           
  Lines        7553     7553           
=======================================
  Hits         2322     2322           
  Misses       4980     4980           
  Partials      251      251           

@k8s-ci-robot k8s-ci-robot merged commit aa26bbf into kubernetes-sigs:master Dec 8, 2023
9 checks passed
@marquiz marquiz deleted the devel/master-service branch December 8, 2023 14:09
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants