topology-updater: properly handle IPv6 from NODE_ADDRESS #1729
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Need to verify this /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/assign @PiotrProkop |
|
/cherry-pick release-0.16 |
|
@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
thanks! |
|
Tested this on ipv6 cluster on kind. Seems to work as expected. @PiotrProkop PTAL |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 09c59227af5365d10321e63fb1d94598f658155f
|
|
/retest |
Fix the usage of IPv6 addresses for default kubelet configz endpoint.
The default host:port we use for kubelet configz endpoint is
${NODE_ADDRESS}:10250. Previously we errored out if NODE_ADDRESS was an
IPv6 address because we used an incorrect notation (without brackets).
The (IPv6) needs to be enclosed in brackets if specifying the port.
marquiz
force-pushed
the
devel/topology-ipv6
branch
from
8a6ed0e
to
dfbd63b
Compare
|
Force-pushed to re-run the netlify stuff. @PiotrProkop PTAL |
|
Oh, it didn't remove the lgtm label. @PiotrProkop nevermind :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
- Coverage 39.54% 39.51% -0.04%
==========================================
Files 80 80
Lines 7153 7160 +7
==========================================
Hits 2829 2829
- Misses 4064 4071 +7
Partials 260 260
|
|
@marquiz: new pull request created: #1731 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@marquiz: new pull request created: #1732 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix the usage of IPv6 addresses for default kubelet configz endpoint.
The default host:port we use for kubelet configz endpoint is ${NODE_ADDRESS}:10250. Previously we errored out if NODE_ADDRESS was an IPv6 address because we used an incorrect notation (without brackets). The (IPv6) needs to be enclosed in brackets if specifying the port.
Fixes #1727