README: add a kubernetes incubator section #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM, but want to merge #3 first to avoid rebasing again. |
|
@ConnorDoyle Cool, sounds good. LMK if I need a rebase! |
|
Also created our first issue to track graduation criteria here: #4 |
|
@philips rebase please |
cynepco3hahue
pushed a commit
to cynepco3hahue/node-feature-discovery
that referenced
this pull request
Nov 24, 2020
Regenerate grpc files with updated dependencies
e0ne
added a commit
to adrianchiris/node-feature-discovery
that referenced
this pull request
Feb 2, 2021
- Align securityContext with defaults - Remove hard-coded names Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
e0ne
added a commit
to adrianchiris/node-feature-discovery
that referenced
this pull request
Feb 3, 2021
- Volume mounts are read-only now - Default version is 'master' - Added a coment to template files to not not forget to update chart too Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
e0ne
added a commit
to adrianchiris/node-feature-discovery
that referenced
this pull request
Feb 5, 2021
- Align securityContext with defaults - Remove hard-coded names Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
e0ne
added a commit
to adrianchiris/node-feature-discovery
that referenced
this pull request
Feb 5, 2021
- Volume mounts are read-only now - Default version is 'master' - Added a coment to template files to not not forget to update chart too Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
e0ne
added a commit
to adrianchiris/node-feature-discovery
that referenced
this pull request
Feb 16, 2021
swatisehgal
referenced
this pull request
in k8stopologyawareschedwg/node-feature-discovery
May 13, 2021
Documentation capturing enablement of NFD-Topology-Updater in NFD
bebc
added a commit
to bebc/node-feature-discovery
that referenced
this pull request
May 7, 2023
# This is the 1st commit message: Don't create empty annotationkeys when featureAnnotion is empty Signed-off-by: bebc <mchf1990212@gmail.com> # This is the commit message kubernetes-sigs#2: helm: fix mount for nfd-master config Volume/mount setup for the ConfigMap was erroneously inside conditionals so it was not mounted unless TLS was enabled. # This is the commit message kubernetes-sigs#3: nfd-master: fix resync period config option This PR fixes the resync-period configuration option of the nfd-master. In fact, previously, changes were not reflected in the nfd-master at runtime. e2e tests are also implemented to make sure that the fix is already working as expected. Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com> deployment/helm: fix default for kubeletStateDir parameter This parameter is a path in the host system, not a mount path inside the container. deployment/kustomize: drop pod-resources mount for topology-updater This mount is redundant as it's already included in the kubelet state files (/var/lib/kubelet) mount. test/e2e: refactor matching of node properties Implement a new generic type nodeListPropertyMatcher, a generic Gomega matcher for matching basically any property of a set of node objects. We will be using it for verifying labels, annotations, extended resources and taints for now. This moves the tests in a more Gomega'ish direction, leveraging code re-use and providing way more informative error messages in case of test failures. The patch adds a new eventuallyNonControlPlaneNodes helper assertion for asserting all (non-control-plane) nodes in the cluster, intended to replace the ugly simplePoll() helper function. This patch implements a matcher for node labels and converts tests to use it instead of the old checkForNodeLabels helper function. test/e2e: rework annotations matcher Add new MatchAnnotations Gomega matcher and drop the old waitForNfdNodeAnnotations helper function. test/e2e: rework node capacity matching Add new MatchCapacity matcher replacing the old waitForCapacity helper function. test/e2e: rework taints matching Add new MatchTaints matcher replacing the old waitForNfdNodeTaints helper function. Also, drop the now-unused simplePoll() helper function. deployment/helm: avoid overlapping mount paths on topology-updater Mount kubelet podresources socket on an independent path, not under with the kubelet state directory. Otherwise container creation may fail on mount creation if topologyUpdater.kubeletPodResourcesSockPath and/or topologyUpdater.kubeletConfigPath Helm parameters are specified in a certain way. deployment/helm: user dedicated serviceaccount for topology-updater Change the configuration so that, by default, we use a dedicated serviceaccount for topology-updater (similar to topology-gc, nfd-master and nfd-worker). Fix the templates so that the serviceaccount and clusterrolebinding are only created when topology-updater is enabled (clusterrole was already handled this way). This patch also correctly documents the default value of rbac.create parameter of topology-updater and topology-gc. deployment/helm: improve handling of topologyUpdater.kubeletStateFiles Make it possible to disable kubelet state tracking with --set topologyUpdater.kubeletStateFiles="" as the documentation suggests. Also, fix the documentation regarding the default value of topologyUpdater.kubeletStateFiles parameter. topology-updater: use node IP in the default configz URI Use a separate NODE_ADDRESS environment variable in the default value of -kubelet-config-uri (instead of NODE_NAME that was previously used). Also change the kustomize and Helm deployments to set this variable to node IP address. This should make the default deployment more robust, making it work in scenarios where node name does not resolve to the node ip, e.g. nodename != hostname. test Signed-off-by: bebc <mchf1990212@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.