Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS file #441

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Update OWNERS file #441

merged 1 commit into from
Feb 16, 2021

Conversation

adrianchiris
Copy link
Contributor

@adrianchiris adrianchiris commented Feb 15, 2021 •
edited

This commit proposes to add @adrianchiris (me)
as reviewer to NFD.

I have been involved in several contributions to the project
as well as participation in code reviews and issues.

So, i propose to formalize this in the projects OWNERs file

Signed-off-by: Adrian Chiris adrianc@nvidia.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @adrianchiris. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Feb 15, 2021
@adrianchiris
Update OWNERS file
59cc16c 
This commit proposes to add github user adrianchiris (me)
as reviewer to NFD.

I have been involved in several contributions to the project
as well as participation in code reviews and issues.

So, i propose to formalize this in the projects OWNERs file

Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
@zvonkok
Copy link
Contributor

zvonkok commented Feb 15, 2021

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 15, 2021
@zvonkok
Copy link
Contributor

zvonkok commented Feb 15, 2021

@marquiz Can we configure prow to ignore the OWNERS file?

@ArangoGutierrez
Copy link
Contributor

/assign @marquiz

@ArangoGutierrez
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2021
ArangoGutierrez
ArangoGutierrez approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Will rely on @marquiz for lgtm

@marquiz
Copy link
Contributor

marquiz commented Feb 15, 2021

Hmm, @adrianchiris is not a member of the org yet. @adrianchiris have you accepted an invite (did you get one?) to ghe kubernetes-sigs org?

@ArangoGutierrez
Copy link
Contributor

PR kubernetes/org#2499 has been merged, is just on @adrianchiris to accept and become part of the org, before we can merge this PR

@adrianchiris
Copy link
Contributor Author

adrianchiris commented Feb 15, 2021 •
edited

@ArangoGutierrez @marquiz

I did not get an invite (searched inbox/spam) although the PR was merged. Is the process fully automated (of getting the invite) ? do i need to contact anyone ?

@ArangoGutierrez
Copy link
Contributor

@ArangoGutierrez @marquiz

I did not get an invite (searched inbox/spam) although the PR was merged. Is the process fully automated (of getting the invite) ? do i need to contact anyone ?

@mrbobbytables ^

@ArangoGutierrez
Copy link
Contributor

/verify-owners

@ArangoGutierrez
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes-sigs org. You can then trigger verification by writing /verify-owners in a comment.

* adrianchiris
  
  * User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Still no invite @adrianchiris ?

@mrbobbytables
Copy link
Member

It is automatic, the invitation still shows pending in GitHub
@adrianchiris you should be able to goto the root of the org https://github.com/kubernetes-sigs and see an invite there as well.

@adrianchiris
Copy link
Contributor Author

It is automatic, the invitation still shows pending in GitHub
@adrianchiris you should be able to goto the root of the org https://github.com/kubernetes-sigs and see an invite there as well.

Accepted, thanks !

@adrianchiris
Copy link
Contributor Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 16, 2021
@zvonkok
Copy link
Contributor

zvonkok commented Feb 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2021
@marquiz
Copy link
Contributor

marquiz commented Feb 16, 2021

Welcome @adrianchiris , great to have you in the team! 🎉
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianchiris, ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2960f63 into kubernetes-sigs:master Feb 16, 2021
@marquiz marquiz mentioned this pull request Mar 10, 2021
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@marquiz marquiz

@zvonkok zvonkok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adrianchiris @k8s-ci-robot @zvonkok @ArangoGutierrez @marquiz @mrbobbytables