-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NFD master '--instance' flag support to Helm chart #443
Add NFD master '--instance' flag support to Helm chart #443
Conversation
Hi @e0ne. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for this patch @e0ne! |
@ArangoGutierrez thanks for the feedback. I updated PR description. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks good to me
/lgtm
1e0291f
to
88bd80d
Compare
Thanks @e0ne ! I haven't tested/verified this myself, but looks good |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianchiris, e0ne, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
--instance flag was introduce in the e52ec34 commit.
This patch adds ability to configure it in the Helm chard during deployment.