Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfd-master: switch to klog #445

Merged
merged 1 commit into from
Feb 25, 2021
Merged

nfd-master: switch to klog #445

merged 1 commit into from
Feb 25, 2021

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Feb 22, 2021

No description provided.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2021
@marquiz marquiz changed the title Devel/klog nfd-master: switch to klog Feb 23, 2021
@marquiz marquiz force-pushed the devel/klog branch 2 times, most recently from 057d8ce to cf3a075 Compare February 24, 2021 10:07
@ArangoGutierrez ArangoGutierrez mentioned this pull request Feb 24, 2021
Merged
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 24, 2021
@marquiz marquiz marked this pull request as ready for review February 24, 2021 20:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Feb 24, 2021

Have to sleep over this
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Feb 25, 2021

For you to judge 😄
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021
ArangoGutierrez
ArangoGutierrez approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interesting part is going to be on the worker PR
Tested this, and even runned the pods with the operator, all looks and works ok.
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit efa7490 into kubernetes-sigs:master Feb 25, 2021
@marquiz marquiz mentioned this pull request Mar 10, 2021
Closed
32 tasks
@marquiz marquiz deleted the devel/klog branch March 17, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marquiz @k8s-ci-robot @ArangoGutierrez