logs should all be lower case when possible #454
Conversation
k8s-ci-robot
added
size/M
There was a problem hiding this comment.
One nit, again referring to K8s commit message guidelines and the first word in the commit message subject should be capitalized unless it starts with a lowercase symbol or other identifier, specifically.
You add a context, for example (you can come up with something better):
logging: start messages with lower case
ArangoGutierrez
force-pushed
the
all_lowercase
branch
from
fe8079c
to
6bd28ec
Compare
Standarize logs to be lower case. Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
ArangoGutierrez
force-pushed
the
all_lowercase
branch
from
6bd28ec
to
389a8f8
Compare
|
Ready for re-review @marquiz |
There was a problem hiding this comment.
Nice improvement in the coherency of log message, @ArangoGutierrez!
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Standardize logs to be lower cased
Bonus: Fixed a func comment to start with the func name
Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com