Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: unify capitalization of headings #470

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Mar 9, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2021
@marquiz marquiz force-pushed the docs/headings branch 2 times, most recently from 054e0a9 to 881be71 Compare March 9, 2021 14:06
@marquiz
Copy link
Contributor Author

marquiz commented Mar 9, 2021

One more fix to headings pushed...

@zvonkok
Copy link
Contributor

zvonkok commented Mar 10, 2021

I haven't found any guidance on how to treat abbr. in headers but usually it says do not use it. If we're using them how should the abbr. be written NFD or Nfd ?

@marquiz
Copy link
Contributor Author

marquiz commented Mar 10, 2021

I haven't found any guidance on how to treat abbr. in headers but usually it says do not use it.

I think that's prolly a good advise 😄

If we're using them how should the abbr. be written NFD or Nfd ?

As I speculated above, if NFD would be used as a stand-alone abbreviation I'd keep it NFD. However as part of the name of the executable I'd prolly use Nfd

@marquiz marquiz force-pushed the docs/headings branch 2 times, most recently from 29ec5cb to 95a4b9f Compare March 11, 2021 09:59
@marquiz
Copy link
Contributor Author

marquiz commented Mar 11, 2021

Changed headings

  • NFD-Master Commandline Flags -> Command line flags of nfd-master
  • NFD-Worker Commandline Flags -> Command line flags of nfd-worker
  • NFD-Worker Configuration File Reference -> Configuration reference of nfd-worker
  • End-to-End Test Configuration File Reference-> Configuration file reference of end-to-end tests

@zvonkok
Copy link
Contributor

zvonkok commented Mar 11, 2021

Ok enough lamenting, only one nitpick and I would say looking good.

@zvonkok
Copy link
Contributor

zvonkok commented Mar 11, 2021

/lgtm

Never used PR reviews as a pair programming tool :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 344f412 into kubernetes-sigs:master Mar 11, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Mar 11, 2021

Never used PR reviews as a pair programming tool :)

Thanks. Not the fastest one for that but seemed to work 😊

@marquiz marquiz deleted the docs/headings branch March 11, 2021 10:23
@marquiz marquiz mentioned this pull request Mar 16, 2021
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants