Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/utils: show correct source file in gRPC logs #475

Merged
merged 1 commit into from
Mar 11, 2021
Merged

pkg/utils: show correct source file in gRPC logs #475

merged 1 commit into from
Mar 11, 2021

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Mar 11, 2021

Unwind two call frames so that the source (file:line) of the log message
is correctly displayed.

@marquiz
pkg/utils: show correct source file in gRPC logs
fb67a50 
Unwind two call frames so that the source (file:line) of the log message
is correctly displayed.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2021
@zvonkok
Copy link
Contributor

zvonkok commented Mar 11, 2021 •
edited

Hmm, this is really pretty nice, I think I need to have a deep look into klog, I like the fact that you can set the frame depth dynamically for unwinding. What is the default?

@marquiz
Copy link
Contributor Author

marquiz commented Mar 11, 2021

0 is the default, i.e. you'll get the location of the actual klog.Func() call

ArangoGutierrez
ArangoGutierrez reviewed Mar 11, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After dealing with a "too many logs" issue on the operator, this type of PR's bring me joy
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 03f53d8 into kubernetes-sigs:master Mar 11, 2021
@marquiz marquiz deleted the devel/grpc-klog branch March 11, 2021 15:34
@marquiz marquiz mentioned this pull request Mar 16, 2021
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez left review comments

@kad kad Awaiting requested review from kad

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marquiz @k8s-ci-robot @zvonkok @ArangoGutierrez